linux-kernel - Re: [PATCH] staging: qlge: replace deprecated apis pci_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200420084836.GA24518@infradead.org>
Date:   Mon, 20 Apr 2020 01:48:36 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Sidong Yang <realwakka@...il.com>
Cc:     Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: qlge: replace deprecated apis pci_dma_*

On Sun, Apr 19, 2020 at 10:08:16AM +0900, Sidong Yang wrote:
>  	direction =
> -	    (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? PCI_DMA_TODEVICE :
> -	    PCI_DMA_FROMDEVICE;
> +	    (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? DMA_TO_DEVICE :
> +	    DMA_FROM_DEVICE;

Can you unobsfucate this while you are at it?

	if (bit & (CFG_LRQ | CFG_LR | CFG_LCQ))
		direction = DMA_TO_DEVICE;
	else
		direction = DMA_FROM_DEVICE;

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@....de>