lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Apr 2020 12:09:13 +0300 From: Mika Westerberg <mika.westerberg@...ux.intel.com> To: Ani Sinha <ani@...sinha.ca> Cc: linux-kernel@...r.kernel.org, ani@...rban.org, Bjorn Helgaas <bhelgaas@...gle.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Keith Busch <keith.busch@...el.com>, Frederick Lawler <fred@...dlawl.com>, Denis Efremov <efremov@...ux.com>, Lukas Wunner <lukas@...ner.de>, linux-pci@...r.kernel.org Subject: Re: [PATCH] PCI: pciehp: Cleanup unused HP_SUPR_RM macro On Sun, Apr 19, 2020 at 07:06:20PM +0530, Ani Sinha wrote: > We do not use PCIE hotplug surprise (PCI_EXP_SLTCAP_HPS) bit anymore. > Consequently HP_SUPR_RM() macro is not used in the kernel source anymore. > Let's clean it up. > > Signed-off-by: Ani Sinha <ani@...sinha.ca> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com> BTW, there seem to be other macros like EMI() that is not used anymore so maybe worth removing them as well. > --- > drivers/pci/hotplug/pciehp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h > index ae44f46..5747967 100644 > --- a/drivers/pci/hotplug/pciehp.h > +++ b/drivers/pci/hotplug/pciehp.h > @@ -148,7 +148,6 @@ struct controller { > #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP) > #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP) > #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP) > -#define HP_SUPR_RM(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_HPS) > #define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP) > #define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS) > #define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19) > -- > 2.7.4
Powered by blists - more mailing lists