linux-kernel - Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200420122859.2a210268@collabora.com>
Date:   Mon, 20 Apr 2020 12:28:59 +0200
From:   Boris Brezillon <boris.brezillon@...labora.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...el.com>,
        "Ramuthevar,Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:MEMORY TECHNOLOGY..." <linux-mtd@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh R <vigneshr@...com>, Arnd Bergmann <arnd@...db.de>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Anders Roxell <anders.roxell@...aro.org>,
        masonccyang@...c.com.tw, piotrs@...ence.com,
        Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org,
        "hauke.mehrtens" <hauke.mehrtens@...el.com>, qi-ming.wu@...el.com,
        cheol.yong.kim@...el.com
Subject: Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on
 Intel LGM SoC

On Mon, 20 Apr 2020 13:14:42 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Mon, Apr 20, 2020 at 12:53 PM Boris Brezillon
> <boris.brezillon@...labora.com> wrote:
> > On Mon, 20 Apr 2020 12:44:51 +0300
> > Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> >  
> > > On Mon, Apr 20, 2020 at 12:21 PM Boris Brezillon
> > > <boris.brezillon@...labora.com> wrote:  
> > > > On Mon, 20 Apr 2020 01:20:40 +0300
> > > > Andy Shevchenko <andriy.shevchenko@...el.com> wrote:  
> > > > > On Sat, Apr 18, 2020 at 10:55:33AM +0200, Boris Brezillon wrote:  
> > > > > > On Fri, 17 Apr 2020 16:21:47 +0800
> > > > > > "Ramuthevar,Vadivel MuruganX"
> > > > > > <vadivel.muruganx.ramuthevar@...ux.intel.com> wrote:
> > > > > >  
> > > > > > > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>  
> > > > >  
> > > > > > > +static const struct of_device_id lgm_nand_match[] = {
> > > > > > > + { .compatible = "intel,lgm-nand", },
> > > > > > > + {}
> > > > > > > +};
> > > > > > > +MODULE_DEVICE_TABLE(of, lgm_nand_match);  
> > > > > >
> > > > > > You probably have a missing "depends on OF" in your Kconfig.  
> > > > >
> > > > > Since it's using device property API, dependency is not needed.
> > > > >  
> > > >
> > > > There's no compile-time dependency, but this driver will be pretty
> > > > useless if all its users have the NAND controller node defined in their
> > > > DT and CONFIG_OF is not enabled.  
> > >
> > > No, it's not.
> > > See [1] for the details how ACPI may utilize this table.
> > >
> > > [1]: https://www.kernel.org/doc/html/latest/firmware-guide/acpi/enumeration.html#device-tree-namespace-link-device-id  
> >
> > Except the NAND framework does use the OF lib when parsing common DT
> > properties (like nand-ecc-mode, etc), so it does depend on OF if you
> > want those props to be parsed, which, according to the DT binding patch,
> > is the case.  
> 
> I see, so, NAND framework can be transformed at some point. In any
> case, from driver perspective it's OF independent.
> 

Well, it uses it only if the driver passes an OF node which this driver
does (see the nand_set_flash_node() call), so no, it's really a driver
dependency.