linux-kernel - Re: [PATCH] vdso/datapage: use correct clock mode name in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <240095f3-a6f8-5815-1b5d-2c0a639b3525@arm.com>
Date:   Mon, 20 Apr 2020 12:17:19 +0100
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Christian Brauner <christian.brauner@...ntu.com>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Cc:     Dmitry Safonov <0x7f454c46@...il.com>,
        Andrei Vagin <avagin@...il.com>,
        Dmitry Safonov <dima@...sta.com>
Subject: Re: [PATCH] vdso/datapage: use correct clock mode name in comment

On 4/20/20 11:06 AM, Christian Brauner wrote:
> While the explanation for time namespace <-> vdso interactions is very
> helpful it uses the wrong name in the comment when describing the clock
> mode making grepping a bit annoying.
> 
> This seems like an accidental oversight when moving from VCLOCK_TIMENS
> to VDSO_CLOCKMODE_TIMENS. It seems that
> 660fd04f9317 ("lib/vdso: Prepare for time namespace support") misspelled
> VCLOCK_TIMENS as VLOCK_TIMENS which explains why it got missed when
> VCLOCK_TIMENS became VDSO_CLOCKMODE_TIMENS in
> 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes").
> 
> Update the commit to use VDSO_CLOCKMODE_TIMENS.
>

Probably you want to add that this patch adds no functional changes, just to
make it explicit.
Otherwise:

Acked-by: Vincenzo Frascino <vincenzo.frascino@....com>

> Cc: Vincenzo Frascino <vincenzo.frascino@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Dmitry Safonov <dima@...sta.com>
> Cc: Andrei Vagin <avagin@...il.com>
> Fixes: 660fd04f9317 ("lib/vdso: Prepare for time namespace support")
> Fixes: 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes")
> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
> ---
>  include/vdso/datapage.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
> index 5cbc9fcbfd45..7955c56d6b3c 100644
> --- a/include/vdso/datapage.h
> +++ b/include/vdso/datapage.h
> @@ -73,8 +73,8 @@ struct vdso_timestamp {
>   *
>   * @offset is used by the special time namespace VVAR pages which are
>   * installed instead of the real VVAR page. These namespace pages must set
> - * @seq to 1 and @clock_mode to VLOCK_TIMENS to force the code into the
> - * time namespace slow path. The namespace aware functions retrieve the
> + * @seq to 1 and @clock_mode to VDSO_CLOCKMODE_TIMENS to force the code into
> + * the time namespace slow path. The namespace aware functions retrieve the
>   * real system wide VVAR page, read host time and add the per clock offset.
>   * For clocks which are not affected by time namespace adjustment the
>   * offset must be zero.
> 
> base-commit: ae83d0b416db002fe95601e7f97f64b59514d936
> 

-- 
Regards,
Vincenzo