linux-kernel - RE: [PATCH v3] exfat: replace 'time_ms' with 'time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Apr 2020 11:51:42 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Tetsuhiro Kohada'" <kohada.t2@...il.com>,
        "'Tetsuhiro Kohada'" <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
Cc:     <Mori.Takahiro@...MitsubishiElectric.co.jp>,
        <motai.hirotaka@...mitsubishielectric.co.jp>,
        "'Sungjong Seo'" <sj1557.seo@...sung.com>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'

> On 2020/04/17 11:39, Namjae Jeon wrote:
> >> Replace "time_ms"  with "time_cs" in the file directory entry
> >> structure and related functions.
> >>
> >> The unit of create_time_ms/modify_time_ms in File Directory Entry are
> >> not 'milli-second', but 'centi-second'.
> >> The exfat specification uses the term '10ms', but instead use 'cs' as
> >> in "msdos_fs.h".
> >>
> >> Signed-off-by: Tetsuhiro Kohada
> >> <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
> >> ---
> > I have run checkpatch.pl on your patch.
> > It give a following warning.
> >
> > WARNING: Missing Signed-off-by: line by nominal patch author
> > 'Tetsuhiro Kohada <Kohada.Tetsuhiro@...mitsubishielectric.co.jp>'
> > total: 0 errors, 1 warnings, 127 lines checked
> >
> > Please fix it.
> 
> I want to fix it, but I'm not sure what's wrong.
> The my patch has the following line:
> 
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
> 
> Both my real name and email address are correct.
> Can you give me some advice?
Your address in author line of this patch seems to be different with Your Signed-off-by.

From: Tetsuhiro Kohada <Kohada.Tetsuhiro@...mitsubishielectric.co.jp>
!=
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>

What is correct one between the two?
I guess you should fix your mail address in your .gitconfig
Or manually add From: your address under subject in your patch like this.
-------------------------------------------------------------------------------
Subject: [PATCH v3] exfat: replace 'time_ms' with 'time_cs'
From: Tetsuhiro Kohada <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>

Replace "time_ms"  with "time_cs" in the file directory entry structure
and related functions.

The unit of create_time_ms/modify_time_ms in File Directory Entry are not
'milli-second', but 'centi-second'.
The exfat specification uses the term '10ms', but instead use 'cs' as in
"msdos_fs.

Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
--------------------------------------------------------------------------------

> 
> *** Currently I can't use office email, so I'm sending it from private
> email instead.
> 
> 
> --
> このEメールはアバスト アンチウイルスによりウイルススキャンされています。
> https://www.avast.com/antivirus