linux-kernel - Re: [PATCH v9 00/17] Enable FSGSBASE instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4764C01A-D225-46FF-A9AF-BAA9CD3EB41C@intel.com>
Date:   Tue, 21 Apr 2020 17:15:34 +0000
From:   "Bae, Chang Seok" <chang.seok.bae@...el.com>
To:     Sasha Levin <sashal@...nel.org>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Andi Kleen <ak@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        "Metzger, Markus T" <markus.t.metzger@...el.com>,
        "hpa@...or.com" <hpa@...or.com>, "bp@...en8.de" <bp@...en8.de>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        Pedro Alves <palves@...hat.com>,
        Simon Marchi <simark@...ark.ca>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 00/17] Enable FSGSBASE instructions


> On Apr 21, 2020, at 09:06, Sasha Levin <sashal@...nel.org> wrote:
> 
> Andi's point is that there is no known user it breaks, and the Intel
> folks did some digging into potential users who might be affected by
> this, including 'rr' brought up by Andy, and concluded that there won't
> be breakage as a result of this patchset:

FWIW, we surveyed tools like rr and CRIU before. Their comments are [*,**]:

   "Anyway I think rr will be fine with the new behavior. Our modifications
    to fs/gs/fs_base/gs_base are always either a) setting values that the
    kernel set during recording to make them happen during replay or b)
    emulating PTRACE_SET_REGS that a tracee ptracer tried to set on another
    tracee. Either way I think the effects are going to be the same as what
    would happen if the program were run without rr.”

   "Internally in criu we fetch the regset via ptrace and keep them in
    images as they were at moment of dump (if ldt is being used we don't
    support such tasks) so I think the changes should not break criu."

What we took away was that those tools reactively follow the underlying
kernel's behavior; so, they should be fine with the FSGSBASE-brought new
behaviors.

[*] https://mail.mozilla.org/pipermail/rr-dev/2018-March/000615.html
[**] https://lists.openvz.org/pipermail/criu/2018-March/040654.html

Thanks,
Chang