linux-kernel - Re: [PATCH v2] tpm/tpm_tis: Free IRQ if probing fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200421195403.GA46589@linux.intel.com>
Date:   Tue, 21 Apr 2020 22:54:03 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     linux-integrity@...r.kernel.org, stable@...r.kernel.org,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] tpm/tpm_tis: Free IRQ if probing fails

On Tue, Apr 21, 2020 at 03:23:19PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 4/16/20 6:07 PM, Jarkko Sakkinen wrote:
> > Call disable_interrupts() if we have to revert to polling in order not to
> > unnecessarily reserve the IRQ for the life-cycle of the driver.
> > 
> > Cc: stable@...r.kernel.org # 4.5.x
> > Reported-by: Hans de Goede <hdegoede@...hat.com>
> > Fixes: e3837e74a06d ("tpm_tis: Refactor the interrupt setup")
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> 
> I can confirm that this fixes the "irq 31 nobody cared" oops for me:
> 
> Tested-by: Hans de Goede <hdegoede@...hat.com>

Hi, thanks a lot! Unfortunately I already put this out given the
criticality of the issue:

https://lkml.org/lkml/2020/4/20/1544

Sincere apologies that I couldn't include your tested-by but the most
important thing is to know that it works now.

/Jarkko