linux-kernel - Re: [GIT PULL] clang-format for v5.7-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVhWREzzjnXH4j+dcnP-GbSMnT_07qVrZM8huAhx6wtVw@mail.gmail.com>
Date:   Tue, 21 Apr 2020 14:03:22 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] clang-format for v5.7-rc3

On Tue, Apr 21, 2020 at 12:10 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Mon, Apr 20, 2020 at 12:09 PM Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
> >
> >  - Don't indent C++ namespaces (Ian Rogers)
>
> I've taken this, since it doesn't matter, but I'm wondering at the
> motivation for it (exactly because it shouldn't matter).

Hi Linus!

We (Google, Stephane Eranian, ..) have a tool that converts Intel's
topdown metrics:
https://download.01.org/perfmon/TMA_Metrics.xlsx
into the json format used for metrics in perf. It is written in C++
and we are planning to upstream it. In C++ there is preference for
anonymous namespaces over static functions and the namespace
indentation was pretty annoying for this. There's a little more
motivation in the commit message too.

Thanks,
Ian Rogers

>                    Linus