linux-kernel - Re: [PATCH] scsi: mpt3sas: use true,false for bool variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+RiK65vudpB_YEM07ydUACD601n4gC-3VSoYA3mJDATAm6L7g@mail.gmail.com>
Date:   Tue, 21 Apr 2020 11:44:32 +0530
From:   Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>,
        Chaitra Basappa <chaitra.basappa@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        PDL-MPT-FUSIONLINUX <MPT-FusionLinux.pdl@...adcom.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: mpt3sas: use true,false for bool variables

Acked-by: Suganath Prabu <suganath-prabu.subramani@...adcom.com>

Thanks.



On Tue, Apr 21, 2020 at 9:12 AM Jason Yan <yanaijie@...wei.com> wrote:
>
> Fix the following coccicheck warning:
>
> drivers/scsi/mpt3sas/mpt3sas_base.c:416:6-14: WARNING: Assignment of 0/1
> to bool variable
> drivers/scsi/mpt3sas/mpt3sas_base.c:485:2-10: WARNING: Assignment of 0/1
> to bool variable
>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 06285b03fa00..4544ba4bf47d 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -413,7 +413,7 @@ static void _clone_sg_entries(struct MPT3SAS_ADAPTER *ioc,
>  {
>         Mpi2SGESimple32_t *sgel, *sgel_next;
>         u32  sgl_flags, sge_chain_count = 0;
> -       bool is_write = 0;
> +       bool is_write = false;
>         u16 i = 0;
>         void __iomem *buffer_iomem;
>         phys_addr_t buffer_iomem_phys;
> @@ -482,7 +482,7 @@ static void _clone_sg_entries(struct MPT3SAS_ADAPTER *ioc,
>
>         if (le32_to_cpu(sgel->FlagsLength) &
>                         (MPI2_SGE_FLAGS_HOST_TO_IOC << MPI2_SGE_FLAGS_SHIFT))
> -               is_write = 1;
> +               is_write = true;
>
>         for (i = 0; i < MPT_MIN_PHYS_SEGMENTS + ioc->facts.MaxChainDepth; i++) {
>
> --
> 2.21.1
>