linux-kernel - Re: [PATCH v3 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Apr 2020 03:44:02 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mathieu Othacehe <m.othacehe@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.

On Mon, Apr 20, 2020 at 11:44 AM Mathieu Othacehe <m.othacehe@...il.com> wrote:
>
> Add sampling frequency support for ambient light and proximity data on
> VCNL4010 and VCNL4020 chips.

...

> +static struct attribute *vcnl4010_attributes[] = {
> +       &iio_const_attr_in_illuminance_sampling_frequency_available.dev_attr.attr,
> +       &iio_const_attr_in_proximity_sampling_frequency_available.dev_attr.attr,

> +       NULL,

No comma for terminator line.

> +};
...

> +static const struct attribute_group vcnl4010_attribute_group = {
> +       .attrs = vcnl4010_attributes

Leave comma at the end in struct member definition.

> +};

-- 
With Best Regards,
Andy Shevchenko