linux-kernel - Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'priority'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6166e9e-46e1-5e4f-e93a-a3c170e81efb@amd.com>
Date:   Tue, 21 Apr 2020 09:14:27 +0200
From:   Christian König <christian.koenig@....com>
To:     YueHaibing <yuehaibing@...wei.com>, alexander.deucher@....com,
        David1.Zhou@....com, airlied@...ux.ie, daniel@...ll.ch,
        andrey.grodzovsky@....com
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/amdgpu: remove set but not used variable
 'priority'

Am 21.04.20 um 04:41 schrieb YueHaibing:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c: In function amdgpu_job_submit:
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:148:26: warning: variable priority set but not used [-Wunused-but-set-variable]
>
> commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init")
> left behind this, remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 35c381ec0423..47207188c569 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -145,7 +145,6 @@ void amdgpu_job_free(struct amdgpu_job *job)
>   int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
>   		      void *owner, struct dma_fence **f)
>   {
> -	enum drm_sched_priority priority;
>   	int r;
>   
>   	if (!f)
> @@ -157,7 +156,6 @@ int amdgpu_job_submit(struct amdgpu_job *job, struct drm_sched_entity *entity,
>   
>   	*f = dma_fence_get(&job->base.s_fence->finished);
>   	amdgpu_job_free_resources(job);
> -	priority = job->base.s_priority;
>   	drm_sched_entity_push_job(&job->base, entity);
>   
>   	return 0;