linux-kernel - RE: [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Apr 2020 06:29:20 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Avri Altman'" <Avri.Altman@....com>, <robh@...nel.org>
Cc:     <devicetree@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <krzk@...nel.org>, <martin.petersen@...cle.com>,
        <kwmad.kim@...sung.com>, <stanley.chu@...iatek.com>,
        <cang@...eaurora.org>, <linux-samsung-soc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for
 Exynos SoCs

Hi Avri,

> -----Original Message-----
> From: Avri Altman <Avri.Altman@....com>
> Sent: 20 April 2020 15:56
> To: Alim Akhtar <alim.akhtar@...sung.com>; robh@...nel.org
> Cc: devicetree@...r.kernel.org; linux-scsi@...r.kernel.org; krzk@...nel.org;
> martin.petersen@...cle.com; kwmad.kim@...sung.com;
> stanley.chu@...iatek.com; cang@...eaurora.org; linux-samsung-
> soc@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Subject: RE: [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for Exynos
> SoCs
> 
> > +       struct exynos_ufs_drv_data *drv_data;
> > +
> > +       u32 opts;
> > +#define EXYNOS_UFS_OPT_HAS_APB_CLK_CTRL                BIT(0)
> > +#define EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB   BIT(1)
> > +#define EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL    BIT(2)
> > +#define EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX       BIT(3)
> > +#define EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER    BIT(4)
> Could not find where the last 2 are being used.
> 
The assignment is done on line# 988 and 989 in exynos_ufs_init() and used in {pre,post}_hibern8, 
let me see if I can add these in the list of .opts in drv_data.
Thanks for pointing this out.

> Thanks,
> Avri