linux-kernel - Re: [PATCH V2] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c972a800-9a38-8f17-09f8-12058bf4491d@web.de>
Date:   Tue, 21 Apr 2020 10:20:21 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Bernard Zhao <bernard@...o.com>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Felix Kühling <Felix.Kuehling@....com>
Cc:     1587180037-113840-1-git-send-email-bernard@...o.com,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
        opensource.kernel@...o.com
Subject: Re: [PATCH V2] drm/amdgpu: Remove an unnecessary condition check in
 reserve_bo_and_cond_vms()

> There is no need to if check again,

Thanks for this information.

* Should the function name be mentioned in this commit message?

* Would you like to adjust the patch subject another bit?

> maybe we could merge into the above else branch.

I suggest to reconsider this wording.
Are you still unsure about the next changes?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ae83d0b416db002fe95601e7f97f64b59514d936#n151

How do you think about to add the tag “Fixes”?

It can be nicer if all patch reviewers (including me) will be explicitly specified
as recipients for such messages, can't it?

Regards,
Markus