linux-kernel - Re: [PATCH v2] drm/amdgpu: Return more error codes in amdgpu_connector_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <34ec6ec4-77aa-9514-f9b2-62c3392d0473@web.de>
Date:   Tue, 21 Apr 2020 11:00:31 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Bernard Zhao <bernard@...o.com>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>
Cc:     linux-kernel@...r.kernel.org, opensource.kernel@...o.com,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        José Roberto de Souza <jose.souza@...el.com>,
        Lyude Paul <lyude@...hat.com>, Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH v2] drm/amdgpu: Return more error codes in
 amdgpu_connector_set_property()

> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.

I suggest to improve the commit message.

* Are you still unsure about the next changes?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ae83d0b416db002fe95601e7f97f64b59514d936#n151

* Would you like to adjust the patch subject another bit?

* How do you think about to add the tag “Fixes”
  because of adjustments for the exception handling?

It can be nicer if all patch reviewers (including me) will be explicitly specified
as recipients for such messages, can't it?

Regards,
Markus