linux-kernel - [add Markus.Elfring in mail list]Re:[PATCH v2] amdgpu: fixes error branch not return errno issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AIgApgB6CE0xGrhst8pSe4p3.3.1587460124439.Hmail.bernard@vivo.com>
Date:   Tue, 21 Apr 2020 17:08:44 +0800 (GMT+08:00)
From:   赵军奎 <bernard@...o.com>
To:     Markus.Elfring@....de
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Lyude Paul <lyude@...hat.com>,
        Sam Ravnborg <sam@...nborg.org>,
        José Roberto de Souza <jose.souza@...el.com>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: [add Markus.Elfring in mail list]Re:[PATCH v2] amdgpu: fixes error branch not return errno issue



From: Bernard Zhao <bernard@...o.com>
Date: 2020-04-21 10:07:50
To:  Alex Deucher <alexander.deucher@....com>,"Christian König" <christian.koenig@....com>,"David (ChunMing) Zhou" <David1.Zhou@....com>,David Airlie <airlied@...ux.ie>,Daniel Vetter <daniel@...ll.ch>,Lyude Paul <lyude@...hat.com>,Sam Ravnborg <sam@...nborg.org>,Bernard Zhao <bernard@...o.com>,"José Roberto de Souza" <jose.souza@...el.com>,Andrzej Pietrasiewicz <andrzej.p@...labora.com>,amd-gfx@...ts.freedesktop.org,dri-devel@...ts.freedesktop.org,linux-kernel@...r.kernel.org
Cc:  opensource.kernel@...o.com
Subject: [PATCH v2] amdgpu: fixes error branch not return errno issue>The "if(!encoder)" branch return the same value 0 of the success
>branch, maybe return -EINVAL is more better.
>
>Signed-off-by: Bernard Zhao <bernard@...o.com>
>
>---
>Changes since V1:
>* commit message improve
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>index f355d9a..1f8c6b4 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
> 		if (!amdgpu_encoder->enc_priv)
>-			return 0;
>+			return -EINVAL;
> 
> 		dig = amdgpu_encoder->enc_priv;
> 		new_coherent_mode = val ? true : false;
>@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>-- 
>2.7.4

>

add Markus.Elfring in mail list 
Regards,
Bernard