linux-kernel - Re: [RFC PATCH v11 1/9] psci: export psci conduit get helper.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3F1930C1-5CBA-4401-9595-1432C16EE750@arm.com>
Date:   Tue, 21 Apr 2020 09:51:25 +0000
From:   Jianyong Wu <Jianyong.Wu@....com>
To:     Mark Rutland <Mark.Rutland@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "yangbo.lu@....com" <yangbo.lu@....com>,
        "john.stultz@...aro.org" <john.stultz@...aro.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "maz@...nel.org" <maz@...nel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "will@...nel.org" <will@...nel.org>,
        Suzuki Poulose <Suzuki.Poulose@....com>,
        Steven Price <Steven.Price@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        Steve Capper <Steve.Capper@....com>,
        Kaly Xin <Kaly.Xin@....com>, Justin He <Justin.He@....com>,
        nd <nd@....com>
Subject: Re: [RFC PATCH v11 1/9] psci: export psci conduit get helper.

Hi Mark,


On 2020/4/21, 5:41 PM, "Mark Rutland" <mark.rutland@....com> wrote:

    On Tue, Apr 21, 2020 at 11:22:56AM +0800, Jianyong Wu wrote:
    > Export arm_smccc_1_1_get_conduit then modules can use smccc helper which
    > adopts it.
    > 
    > Signed-off-by: Jianyong Wu <jianyong.wu@....com>

    Nit: please say 'smccc conduit' in the commit title.

Ok, I will fix it next version.

    Otherwise, I see not problem with this provided an in-tree module uses
    this, so:

    Acked-by: Mark Rutland <mark.rutland@....com>

Thanks! Glad to get this.

Best regards
Jianyong 

    Mark.

    > ---
    >  drivers/firmware/psci/psci.c | 1 +
    >  1 file changed, 1 insertion(+)
    > 
    > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
    > index 2937d44b5df4..fd3c88f21b6a 100644
    > --- a/drivers/firmware/psci/psci.c
    > +++ b/drivers/firmware/psci/psci.c
    > @@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void)
    >  
    >  	return psci_ops.conduit;
    >  }
    > +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit);
    >  
    >  typedef unsigned long (psci_fn)(unsigned long, unsigned long,
    >  				unsigned long, unsigned long);
    > -- 
    > 2.17.1
    >