linux-kernel - Re: [V3] amdgpu: remove unnecessary condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Apr 2020 12:00:12 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Christian König <christian.koenig@....com>,
        赵军奎 <bernard@...o.com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Cc:     Alex Deucher <alexander.deucher@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Felix Kühling <Felix.Kuehling@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, opensource.kernel@...o.com,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Coccinelle <cocci@...teme.lip6.fr>
Subject: Re: [V3] amdgpu: remove unnecessary condition check

>> But i have to say there are so many code not follow the kernel code-style in amdgpu module.
>> And also the ./scripts/checkpatch.pl did not throw any warning or error.
>
> That is unfortunately true, yes. But we try to push new code through the usual code review and improve things as we go.
>
> On the other hand patches just to fix the coding style are usually seen as an unnecessary interruption and just a waste of time.

Would you become interested in adjusting deviations from known programming guidelines
in an automatic way with the help of corresponding advanced development tools?

Regards,
Markus