linux-kernel - Re: [RESEND PATCH v7 4/6] ACPI / APEI: Add callback for ARM HW errors to the GHES notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200421141426.GD2682@kadam>
Date:   Tue, 21 Apr 2020 17:14:26 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Shiju Jose <shiju.jose@...wei.com>
Cc:     linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, rjw@...ysocki.net, bp@...en8.de,
        james.morse@....com, helgaas@...nel.org, lenb@...nel.org,
        tony.luck@...el.com, gregkh@...uxfoundation.org,
        zhangliguang@...ux.alibaba.com, tglx@...utronix.de,
        linuxarm@...wei.com, jonathan.cameron@...wei.com,
        tanxiaofei@...wei.com, yangyicong@...ilicon.com
Subject: Re: [RESEND PATCH v7 4/6] ACPI / APEI: Add callback for ARM HW
 errors to the GHES notifier

On Tue, Apr 21, 2020 at 02:21:34PM +0100, Shiju Jose wrote:
>  static BLOCKING_NOTIFIER_HEAD(ghes_event_notify_list);
> @@ -670,12 +692,7 @@ static void ghes_do_proc(struct ghes *ghes,
>  			pr_warn(GHES_PFX "ghes event queue full\n");
>  			break;
>  		}
> -
> -		if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
> -			struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata);
> -
> -			log_arm_hw_error(err);
> -		} else {
> +		{
>  			void *err = acpi_hest_get_payload(gdata);

This is ugly.  Just move the "void *err;" declaration to the top of the
function so we can delete this block.

>  
>  			log_non_standard_event(sec_type, fru_id, fru_text,
> -- 

regards,
dan carpenter