[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DB3PR0402MB3916B60832507A72F39750EAF5D50@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date: Tue, 21 Apr 2020 14:31:17 +0000
From: Anson Huang <anson.huang@....com>
To: Rob Herring <robh@...nel.org>
CC: "rui.zhang@...el.com" <rui.zhang@...el.com>,
"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
"amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"festevam@...il.com" <festevam@...il.com>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
Hi, Rob
> Subject: Re: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
>
> On Fri, Apr 10, 2020 at 09:07:24AM +0800, Anson Huang wrote:
> > Convert the i.MX thermal binding to DT schema format using json-schema
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> > Changes since V1:
> > - make clock property optional.
> > ---
> > .../devicetree/bindings/thermal/imx-thermal.txt | 61 --------------
> > .../devicetree/bindings/thermal/imx-thermal.yaml | 96
> ++++++++++++++++++++++
> > 2 files changed, 96 insertions(+), 61 deletions(-) delete mode
> > 100644 Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > create mode 100644
> > Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > b/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > deleted file mode 100644
> > index 823e417..0000000
> > +
> > +title: NXP i.MX Thermal Binding
> > +
> > +maintainers:
> > + - Anson Huang <Anson.Huang@....com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - fsl,imx6q-tempmon
> > + - fsl,imx6sx-tempmon
> > + - fsl,imx7d-tempmon
> > +
> > + interrupts:
> > + description: |
> > + The interrupt output of the controller, the IRQ will be triggered
> > + when temperature is higher than high threshold.
> > + maxItems: 1
> > +
> > + nvmem-cells:
> > + description: |
> > + Phandle to the calibration cells provided by ocotp for calibration
> > + data and temperature grade.
> > + maxItems: 2
> > +
> > + nvmem-cell-names:
> > + maxItems: 2
> > + items:
> > + - const: calib
> > + - const: temp_grade
> > +
> > + fsl,tempmon:
> > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > + description: |
> > + Phandle pointer to system controller that contains TEMPMON
> control
> > + registers, e.g. ANATOP on imx6q.
>
> Really, this should have been a child of the system controller. Not too late to
> do that, but you'd need to keep this for compatibility.
Sorry, I don't quite get your point, can you provide more details or example, thanks.
Anson
Powered by blists - more mailing lists