linux-kernel - [PATCH 3/3] dmaengine: ioat: adding missed issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Apr 2020 14:22:07 +0300
From:   leonid.ravich@...l.com
To:     dmaengine@...r.kernel.org
Cc:     lravich@...il.com, Leonid Ravich <Leonid.Ravich@...l.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vkoul@...nel.org>,
        Dave Jiang <dave.jiang@...el.com>,
        Allison Randal <allison@...utok.net>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Alexander.Barabash@...l.com" <Alexander.Barabash@...l.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH 3/3] dmaengine: ioat: adding missed issue_pending to timeout handler

From: Leonid Ravich <Leonid.Ravich@....com>

completion timeout might trigger unnesesery DMA engine hw reboot
in case of missed issue_pending() .

Signed-off-by: Leonid Ravich <Leonid.Ravich@....com>
---
 drivers/dma/ioat/dma.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 55a8cf1..2ab07a3 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -955,6 +955,13 @@ void ioat_timer_event(struct timer_list *t)
 		goto unlock_out;
 	}
 
+	/* handle missed issue pending case */
+	if (ioat_ring_pending(ioat_chan)) {
+		spin_lock_bh(&ioat_chan->prep_lock);
+		__ioat_issue_pending(ioat_chan);
+		spin_unlock_bh(&ioat_chan->prep_lock);
+	}
+
 	set_bit(IOAT_COMPLETION_ACK, &ioat_chan->state);
 	mod_timer(&ioat_chan->timer, jiffies + COMPLETION_TIMEOUT);
 unlock_out:
-- 
1.9.3