linux-kernel - Re: [PATCH] perf stat: Zero ena and run for interval mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200422140415.GE20647@kernel.org>
Date:   Wed, 22 Apr 2020 11:04:15 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jin Yao <yao.jin@...ux.intel.com>, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH] perf stat: Zero ena and run for interval mode

Em Thu, Apr 09, 2020 at 05:43:32PM +0200, Jiri Olsa escreveu:
> On Thu, Apr 09, 2020 at 03:07:55PM +0800, Jin Yao wrote:
> > As the code comments in perf_stat_process_counter() say,
> > we calculate counter's data every interval, and the display
> > code shows ps->res_stats avg value. We need to zero the stats
> > for interval mode.
> > 
> > But the current code only zeros the res_stats[0], it doesn't
> > zero the res_stats[1] and res_stats[2], which are for ena
> > and run of counter.
> > 
> > This patch zeros the whole res_stats[] for interval mode.
> > 
> > Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
> 
> nice catch ;-)
> 
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Thanks, applied, together with the:

51fd2df1e882 ("perf stat: Fix interval output values")

you provided under private cover.

- Arnaldo
 
> thanks,
> jirka
> 
> > ---
> >  tools/perf/util/stat.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
> > index 5f26137b8d60..242476eb808c 100644
> > --- a/tools/perf/util/stat.c
> > +++ b/tools/perf/util/stat.c
> > @@ -368,8 +368,10 @@ int perf_stat_process_counter(struct perf_stat_config *config,
> >  	 * interval mode, otherwise overall avg running
> >  	 * averages will be shown for each interval.
> >  	 */
> > -	if (config->interval)
> > -		init_stats(ps->res_stats);
> > +	if (config->interval) {
> > +		for (i = 0; i < 3; i++)
> > +			init_stats(&ps->res_stats[i]);
> > +	}
> >  
> >  	if (counter->per_pkg)
> >  		zero_per_pkg(counter);
> > -- 
> > 2.17.1
> > 
> 

-- 

- Arnaldo