linux-kernel - Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x

Open Source and information security mailing list archives

Message-ID: <20200422152439.GG974925@lunn.ch>
Date:   Wed, 22 Apr 2020 17:24:39 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakov Petrina <jakov.petrina@...tura.hr>
Cc:     jason@...edaemon.net, devicetree@...r.kernel.org,
        gregory.clement@...tlin.com, linux-kernel@...r.kernel.org,
        vladimir.vid@...tura.hr, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        sebastian.hesselbarth@...il.com,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x

On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> This resolves issues with certain SPF modules.

Hi Jakov

Please could you explain this some more. PHYLINK should be setting the
mode appropriately, based on the capabilities of the SFP module. Is
the real problem that the SFP module is indicating the wrong baud
rate?

	Andrew

> 
> Signed-off-by: Jakov Petrina <jakov.petrina@...tura.hr>
> Signed-off-by: Vladimir Vid <vladimir.vid@...tura.hr>
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index 7eb6c1796cef..b6e2a9c68b2a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -144,7 +144,7 @@ lm75@49 {
>  };
>  
>  &eth0 {
> -	phy-mode = "sgmii";
> +	phy-mode = "2500base-x";
>  	status = "okay";
>  	managed = "in-band-status";
>  	phys = <&comphy1 0>;
> @@ -152,7 +152,7 @@ &eth0 {
>  };
>  
>  &eth1 {
> -	phy-mode = "sgmii";
> +	phy-mode = "2500base-x";
>  	status = "okay";
>  	managed = "in-band-status";
>  	phys = <&comphy0 1>;
> -- 
> 2.24.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives