linux-kernel - Re: [RFC PATCH v3 05/12] fs: add security blob and hooks for block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff87e1ff-b9bf-5879-0154-c72990ce608b@schaufler-ca.com>
Date:   Wed, 22 Apr 2020 09:55:15 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     James Morris <jmorris@...ei.org>, deven.desai@...ux.microsoft.com
Cc:     agk@...hat.com, axboe@...nel.dk, snitzer@...hat.com,
        "Serge E. Hallyn" <serge@...lyn.com>, zohar@...ux.ibm.com,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, dm-devel@...hat.com,
        linux-block@...r.kernel.org, jannh@...gle.com,
        tyhicks@...ux.microsoft.com, pasha.tatashin@...een.com,
        sashal@...nel.org, jaskarankhurana@...ux.microsoft.com,
        nramas@...ux.microsoft.com, mdsakib@...ux.microsoft.com,
        linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        Chad Sellers <csellers@...sys.com>,
        John Johansen <john.johansen@...onical.com>,
        Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [RFC PATCH v3 05/12] fs: add security blob and hooks for
 block_device

On 4/22/2020 9:42 AM, James Morris wrote:
> On Wed, 15 Apr 2020, deven.desai@...ux.microsoft.com wrote:
>
>> From: Deven Bowers <deven.desai@...ux.microsoft.com>
>>
>> Add a security blob and associated allocation, deallocation and set hooks
>> for a block_device structure.
>>
>> Signed-off-by: Deven Bowers <deven.desai@...ux.microsoft.com>
> Is there any feedback from block or LSM folk on the addition of a security 
> blob for block_device here?

The addition of a blob looks to have been done correctly.
As for it's use, I haven't had the chance to review the patches that
use it. I didn't see a patch that implements the hooks in a LSM,
but that could just be me. 

>
> IPE uses this is to track the status of integrity verification of e.g. 
> DM-Verity devices, per this code from a subsequent patch:
>
>
> +       ret = security_bdev_setsecurity(dm_table_get_md(v->ti->table)->bdev,
> +                                       DM_VERITY_SIGNATURE_SEC_NAME,
> +                                       v->sig->sig, v->sig->sig_size);
>
>