linux-kernel - Re: [RESEND PATCH v2 1/2] driver core: platform: Initialize dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200422170349.GA28781@lst.de>
Date:   Wed, 22 Apr 2020 19:03:49 +0200
From:   Christoph Hellwig <hch@....de>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Christoph Hellwig <hch@....de>,
        Russell King <linux@...linux.org.uk>,
        Linus Walleij <linus.walleij@...aro.org>,
        Robin Murphy <robin.murphy@....com>,
        Vinod Koul <vkoul@...nel.org>, Haibo Chen <haibo.chen@....com>,
        Ludovic Barre <ludovic.barre@...com>,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [RESEND PATCH v2 1/2] driver core: platform: Initialize
 dma_parms for platform devices

On Wed, Apr 22, 2020 at 12:09:54PM +0200, Ulf Hansson wrote:
> It's currently the platform driver's responsibility to initialize the
> pointer, dma_parms, for its corresponding struct device. The benefit with
> this approach allows us to avoid the initialization and to not waste memory
> for the struct device_dma_parameters, as this can be decided on a case by
> case basis.
> 
> However, it has turned out that this approach is not very practical.  Not
> only does it lead to open coding, but also to real errors. In principle
> callers of dma_set_max_seg_size() doesn't check the error code, but just
> assumes it succeeds.
> 
> For these reasons, let's do the initialization from the common platform bus
> at the device registration point. This also follows the way the PCI devices
> are being managed, see pci_device_add().
> 
> Suggested-by: Christoph Hellwig <hch@....de>
> Cc: <stable@...r.kernel.org>
> Tested-by: Haibo Chen <haibo.chen@....com>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>