lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Apr 2020 19:22:54 +0200 From: Christoph Hellwig <hch@....de> To: Andrey Ignatov <rdna@...com> Cc: Christoph Hellwig <hch@....de>, Kees Cook <keescook@...omium.org>, Iurii Zaikin <yzaikin@...gle.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, linux-kernel@...r.kernel.org, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org Subject: Re: [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler On Tue, Apr 21, 2020 at 12:23:30PM -0700, Andrey Ignatov wrote: > > if (ret == 1 && ctx.new_updated) { > > - *new_buf = ctx.new_val; > > + *buf = ctx.new_val; > > Original value of *buf should be freed before overriding it here > otherwise it's lost/leaked unless I missed something. > > Other than this BPF part of this patch looks good to me. Feel free to > add my Ack on the next iteration with this fix. Thanks, fixed. Can you also comment on "bpf-cgroup: remove unused exports" ?
Powered by blists - more mailing lists