linux-kernel - Re: [PATCH net v2 0/5] net: dsa: b53: Various ARL fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Apr 2020 12:53:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        linux-kernel@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net v2 0/5] net: dsa: b53: Various ARL fixes

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 20 Apr 2020 20:26:50 -0700

> Hi David, Andrew, Vivien, Jakub,
> 
> This patch series fixes a number of short comings in the existing b53
> driver ARL management logic in particular:
> 
> - we were not looking up the {MAC,VID} tuples against their VID, despite
>   having VLANs enabled
> 
> - the MDB entries (multicast) would lose their validity as soon as a
>   single port in the vector would leave the entry
> 
> - the ARL was currently under utilized because we would always place new
>   entries in bin index #1, instead of using all possible bins available,
>   thus reducing the ARL effective size by 50% or 75% depending on the
>   switch generation
> 
> - it was possible to overwrite the ARL entries because no proper space
>   verification was done
> 
> This patch series addresses all of these issues.
> 
> Changes in v2:
> - added a new patch to correctly flip invidual VLAN learning vs. shared
>   VLAN learning depending on the global VLAN state
> 
> - added Andrew's R-b tags for patches which did not change
> 
> - corrected some verbosity and minor issues in patch #4 to match caller
>   expectations, also avoid a variable length DECLARE_BITMAP() call

Series applied and queued up for -stable, thanks.