linux-kernel - Re: [PATCH 1/5] bpf-cgroup: remove unused exports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200422233908.GA6764@rdna-mbp.dhcp.thefacebook.com>
Date:   Wed, 22 Apr 2020 16:39:08 -0700
From:   Andrey Ignatov <rdna@...com>
To:     Christoph Hellwig <hch@....de>
CC:     Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-fsdevel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <bpf@...r.kernel.org>
Subject: Re: [PATCH 1/5] bpf-cgroup: remove unused exports

Christoph Hellwig <hch@....de> [Tue, 2020-04-21 10:17 -0700]:
> Except for a few of the networking hooks called from modular ipv4 or
> ipv6 code, all of hooks are just called from guaranteed to be built-in
> code.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

I checked it as well it see same thing:

- __cgroup_bpf_check_dev_permission is called in
  security/device_cgroup.c under CONFIG_CGROUP_DEVICE;

- __cgroup_bpf_run_filter_sysctl is called in fs/proc/proc_sysctl.c
  under CONFIG_PROC_SYSCTL;

- __cgroup_bpf_run_filter_[gs]etsockopt is called in net/socket.c under
  CONFIG_NET;

All three configs are bool-s so LGTM.

Acked-by: Andrey Ignatov <rdna@...com>

-- 
Andrey Ignatov