linux-kernel - Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b554ea70-16da-1637-d349-db51dddcf95b@sholland.org>
Date:   Wed, 22 Apr 2020 18:50:54 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

Maxime,

On 4/22/20 10:16 AM, Maxime Ripard wrote:
> On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
>> As of v5.7-rc2, Linux now prints the following message at boot:
>>
>>   [   33.848525] platform sound_spdif: deferred probe pending
>>
>> This is because &sound_spdif is waiting on its DAI link component
>> &spdif to probe, but &spdif is disabled in the DTS. Disable the
>> audio card as well to match.
>>
>> Signed-off-by: Samuel Holland <samuel@...lland.org>
> 
> The patch looks good, but don't we have some boards with SPDIF enabled that
> should be modified accordingly?

I don't see any in-tree. The only A64 DTS that references &spdif at all is
sun50i-a64-pine64.dts, which explicitly disables it:

	/* On Euler connector */
	&spdif {
  		status = "disabled";
	};

I'm leaning toward agreeing with Clement that the sound_spdif node (and also
spdif_out) should be removed altogether from the A64 DTSI.

Regards,
Samuel