linux-kernel - Re: [PATCH] USB: serial: garmin_gps: remove some defined but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200422074908.GJ18608@localhost>
Date:   Wed, 22 Apr 2020 09:49:08 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     johan@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: garmin_gps: remove some defined but not
 used variables

On Thu, Apr 09, 2020 at 04:51:43PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
> 
> drivers/usb/serial/garmin_gps.c:192:28: warning: ‘PRIVATE_REQ’ defined
> but not used [-Wunused-const-variable=]
>  static unsigned char const PRIVATE_REQ[]
>                             ^~~~~~~~~~~
> drivers/usb/serial/garmin_gps.c:186:28: warning: ‘GARMIN_STOP_PVT_REQ’
> defined but not used [-Wunused-const-variable=]
>  static unsigned char const GARMIN_STOP_PVT_REQ[]
>                             ^~~~~~~~~~~~~~~~~~~
> drivers/usb/serial/garmin_gps.c:184:28: warning: ‘GARMIN_START_PVT_REQ’
> defined but not used [-Wunused-const-variable=]
>  static unsigned char const GARMIN_START_PVT_REQ[]
>                             ^~~~~~~~~~~~~~~~~~~~
> drivers/usb/serial/garmin_gps.c:182:28: warning:
> ‘GARMIN_APP_LAYER_REPLY’ defined but not used [-Wunused-const-variable=]
>  static unsigned char const GARMIN_APP_LAYER_REPLY[]
>                             ^~~~~~~~~~~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

You should mention that this is a W=1 one warning which isn't enabled
by default.

> ---
>  drivers/usb/serial/garmin_gps.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
> index ffd984142171..3b39d1e39fbf 100644
> --- a/drivers/usb/serial/garmin_gps.c
> +++ b/drivers/usb/serial/garmin_gps.c
> @@ -179,19 +179,10 @@ static unsigned char const GARMIN_START_SESSION_REPLY[]
>  	= { 0, 0, 0, 0,  6, 0, 0, 0, 4, 0, 0, 0 };
>  static unsigned char const GARMIN_BULK_IN_AVAIL_REPLY[]
>  	= { 0, 0, 0, 0,  2, 0, 0, 0, 0, 0, 0, 0 };
> -static unsigned char const GARMIN_APP_LAYER_REPLY[]
> -	= { 0x14, 0, 0, 0 };
> -static unsigned char const GARMIN_START_PVT_REQ[]
> -	= { 20, 0, 0, 0,  10, 0, 0, 0, 2, 0, 0, 0, 49, 0 };
> -static unsigned char const GARMIN_STOP_PVT_REQ[]
> -	= { 20, 0, 0, 0,  10, 0, 0, 0, 2, 0, 0, 0, 50, 0 };
>  static unsigned char const GARMIN_STOP_TRANSFER_REQ[]
>  	= { 20, 0, 0, 0,  10, 0, 0, 0, 2, 0, 0, 0, 0, 0 };
>  static unsigned char const GARMIN_STOP_TRANSFER_REQ_V2[]
>  	= { 20, 0, 0, 0,  10, 0, 0, 0, 1, 0, 0, 0, 0 };
> -static unsigned char const PRIVATE_REQ[]
> -	=    { 0x4B, 0x6E, 0x10, 0x01,  0xFF, 0, 0, 0, 0xFF, 0, 0, 0 };
> -

I'm reluctant to simply remove these as they document the protocol
without any real downsides besides the W=1 warning.

Johan