linux-kernel - Re: [PATCH 1/9] vboxsf: don't use the source name in the bdi name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2db7b68b-5117-4dab-ce57-6e8011711c23@redhat.com>
Date:   Wed, 22 Apr 2020 10:15:32 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Christoph Hellwig <hch@....de>, axboe@...nel.dk
Cc:     yuyufen@...wei.com, tj@...nel.org, jack@...e.cz,
        bvanassche@....org, tytso@....edu, gregkh@...uxfoundation.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] vboxsf: don't use the source name in the bdi name

Hi,

On 4/22/20 9:38 AM, Christoph Hellwig wrote:
> Simplify the bdi name to mirror what we are doing elsewhere, and
> drop them name in favor of just using a number.  This avoids a
> potentially very long bdi name.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   fs/vboxsf/super.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
> index 675e26989376..8fe03b4a0d2b 100644
> --- a/fs/vboxsf/super.c
> +++ b/fs/vboxsf/super.c
> @@ -164,7 +164,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
>   		goto fail_free;
>   	}
>   
> -	err = super_setup_bdi_name(sb, "vboxsf-%s.%d", fc->source, sbi->bdi_id);
> +	err = super_setup_bdi_name(sb, "vboxsf-%d", sbi->bdi_id);
>   	if (err)
>   		goto fail_free;
>   
>