linux-kernel - Re: [PATCH v4 2/4] iio: vcnl4000: Add event support for VCNL4010/20.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfE-0Uw1ii1P1Sen8fuoiiXjqxQTBOx_11rzXfHiQchkA@mail.gmail.com>
Date:   Wed, 22 Apr 2020 11:25:58 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mathieu Othacehe <m.othacehe@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/4] iio: vcnl4000: Add event support for VCNL4010/20.

On Wed, Apr 22, 2020 at 11:02 AM Mathieu Othacehe <m.othacehe@...il.com> wrote:

> >> +               ret = devm_request_threaded_irq(&client->dev, client->irq,
> >> +                                               NULL, vcnl4010_irq_thread,
> >> +                                               IRQF_TRIGGER_FALLING |
> >
> >> +                                               IRQF_ONESHOT,
> >
> > Isn't it by default when threaded IRQ is asked with NULL for hw handler?
>
> No, and it fails with this error message if IRQF_ONESHOT is not set:
>
> pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",

Ok, thanks.

-- 
With Best Regards,
Andy Shevchenko