linux-kernel - Re: [PATCH v2 06/10] mmc: meson-mx-sdio: Depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Apr 2020 12:39:00 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        kbuild test robot <lkp@...el.com>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH v2 06/10] mmc: meson-mx-sdio: Depend on OF_ADDRESS and not
 just OF

On Wed, 22 Apr 2020 at 12:14, Stephen Boyd <sboyd@...nel.org> wrote:
>
> Quoting Ulf Hansson (2020-04-21 07:04:54)
> > On Thu, 9 Apr 2020 at 08:44, Stephen Boyd <sboyd@...nel.org> wrote:
> > >
> > > Making COMMON_CLK a visible option causes the sparc allyesconfig to fail
> > > to build like so:
> > >
> > >    sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_remove':
> > >    meson-mx-sdio.c:(.text+0x70): undefined reference to `of_platform_device_destroy'
> > >    sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_probe':
> > >    meson-mx-sdio.c:(.text+0x9e4): undefined reference to `of_platform_device_create'
> > >    sparc64-linux-ld: meson-mx-sdio.c:(.text+0xdd4): undefined reference to `of_platform_device_destroy'
> > >
> > > This is because the implementation of of_platform_device_destroy() is
> > > inside an #ifdef CONFIG_OF_ADDRESS section of drivers/of/platform.c.
> > > This driver already depends on OF being enabled, so let's tighten that
> > > constrain a little more so that it depends on OF_ADDRESS instead. This
> > > way we won't try to build this driver on platforms that don't have this
> > > function.
> > >
> > > Reported-by: kbuild test robot <lkp@...el.com>
> > > Cc: Neil Armstrong <narmstrong@...libre.com>
> > > Cc: Ulf Hansson <ulf.hansson@...aro.org>
> > > Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> >
> > I don't have the complete picture here, can I just apply this a fix to
> > my mmc tree?
> >
>
> If this patch stays in the series then I can avoid a bisection hole. And
> it also doesn't matter until COMMON_CLK config becomes selectable. Maybe
> just ack and let it go through clk tree? Unless there's something
> changing here in the mmc tree?

This file is likely to change in my mmc-tree. However, let's deal with
the conflict, if/when that happens. So, please pick it through your
clock tree.

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe