linux-kernel - Re: [EXT] Re: [PATCH v2 1/5] scsi; ufs: add device descriptor for Host Performance Booster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2625027d-8d98-3f30-93d4-dc1c39a434f1@acm.org>
Date:   Thu, 23 Apr 2020 10:57:17 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "Bean Huo (beanhuo)" <beanhuo@...ron.com>,
        "huobean@...il.com" <huobean@...il.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH v2 1/5] scsi; ufs: add device descriptor for
 Host Performance Booster

On 4/23/20 4:01 AM, Bean Huo (beanhuo) wrote:
> Thanks your review, I will take your suggestions in next version development.

Hi Bean,

Please make sure that the issues raised by Christoph are addressed 
before reposting this series.

Additionally, I think the following two call chains are deadlock-prone 
and should be addressed:

ufshcd_queuecommand()
-> ufshcd_comp_scsi_upiu()
   -> ufshpb_prep_fn()
     -> schedule_work(&hpb->ufshpb_req_work)
       -> ufshpb_req_workq_fn()
         -> ufshpb_subregion_activate()
           -> ufshpb_subregion_l2p_load()
             -> ufshpb_l2p_load_req()
               -> blk_execute_rq_nowait()

ufshcd_queuecommand()
-> ufshcd_comp_scsi_upiu()
   -> ufshpb_prep_fn()
     -> schedule_work(&hpb->ufshpb_req_work)
       -> ufshpb_req_workq_fn()
         -> ufshpb_subregion_activate()
         -> ufshpb_region_deactivate()
           -> ufshpb_execute_cmd()
             -> scsi_execute()

I don't know any other block or SCSI driver that calls blk_execute_rq*() 
or scsi_execute() from inside its .queue_rq() callback to queue requests 
onto the same request queue (the device mapper requeues requests onto a 
lower level request queue).

Thanks,

Bart.