linux-kernel - Re: [PATCH] drivers: dma: pch_dma.c: Avoid data race between probe and irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200423181334.GA23094@madhuparna-HP-Notebook>
Date:   Thu, 23 Apr 2020 23:43:35 +0530
From:   Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     madhuparnabhowmik10@...il.com, dan.j.williams@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        andrianov@...ras.ru, ldv-project@...uxtesting.org
Subject: Re: [PATCH] drivers: dma: pch_dma.c: Avoid data race between probe
 and irq handler

On Thu, Apr 23, 2020 at 11:49:35AM +0530, Vinod Koul wrote:
> On 16-04-20, 11:53, madhuparnabhowmik10@...il.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> > 
> > pd->dma.dev is read in irq handler pd_irq().
> > However, it is set to pdev->dev after request_irq().
> > Therefore, set pd->dma.dev to pdev->dev before request_irq() to
> > avoid data race between pch_dma_probe() and pd_irq().
> 
> Please use the right subsystem tag for patch. You can find that using
> git log on the respective subsystem, in this case it would have told you
> that it is dmaengine.
>
Sure, I will take care of this.

> I have fixed that up and applied it, thanks for the patch
>
Thank you,
Madhuparna
> -- 
> ~Vinod