linux-kernel - Re: [PATCH] PCI: pciehp: Cleanup unused EMI() and HP_SUPR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200423184732.GA203039@google.com>
Date:   Thu, 23 Apr 2020 13:47:32 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ani Sinha <ani@...sinha.ca>
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Keith Busch <keith.busch@...el.com>,
        Frederick Lawler <fred@...dlawl.com>,
        Denis Efremov <efremov@...ux.com>,
        Alexandru Gagniuc <mr.nuke.me@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Cleanup unused EMI() and HP_SUPR_RM() macros

On Tue, Apr 21, 2020 at 08:57:50AM +0530, Ani Sinha wrote:
> We do not use PCIE hotplug surprise (PCI_EXP_SLTCAP_HPS) bit anymore.
> Consequently HP_SUPR_RM() macro is no longer used. Let's clean it up.
> EMI() macro also seems to be unused. So removing it as well. Thanks
> Mika Westerberg <mika.westerberg@...ux.intel.com> for
> pointing it out.
> 
> Signed-off-by: Ani Sinha <ani@...sinha.ca>
> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Applied to pci/hotplug for v5.8, thanks!

> ---
>  drivers/pci/hotplug/pciehp.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> index ae44f46..4fd200d 100644
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -148,8 +148,6 @@ struct controller {
>  #define MRL_SENS(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
>  #define ATTN_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
>  #define PWR_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> -#define HP_SUPR_RM(ctrl)	((ctrl)->slot_cap & PCI_EXP_SLTCAP_HPS)
> -#define EMI(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
>  #define NO_CMD_CMPL(ctrl)	((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
>  #define PSN(ctrl)		(((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
>  
> -- 
> 2.7.4
>