linux-kernel - Re: [v3,net-next 1/4] net: qos: introduce a gate control flow action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 21:17:47 +0200
From:   "Allan W. Nielsen" <allan.nielsen@...rochip.com>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
CC:     Po Liu <Po.Liu@....com>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <claudiu.manoil@....com>, <vladimir.oltean@....com>,
        <alexandru.marginean@....com>, <michael.chan@...adcom.com>,
        <vishal@...lsio.com>, <saeedm@...lanox.com>, <leon@...nel.org>,
        <jiri@...lanox.com>, <idosch@...lanox.com>,
        <alexandre.belloni@...tlin.com>, <UNGLinuxDriver@...rochip.com>,
        <kuba@...nel.org>, <jhs@...atatu.com>, <xiyou.wangcong@...il.com>,
        <simon.horman@...ronome.com>, <pablo@...filter.org>,
        <moshe@...lanox.com>, <m-karicheri2@...com>,
        <andre.guedes@...ux.intel.com>, <stephen@...workplumber.org>
Subject: Re: [v3,net-next  1/4] net: qos: introduce a gate control flow action

On 23.04.2020 10:38, Vinicius Costa Gomes wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>Po Liu <Po.Liu@....com> writes:
>>> tc filter add dev eth0 parent ffff: protocol ip \
>>          flower src_ip 192.168.0.20 \
>>          action gate index 2 clockid CLOCK_TAI \
>>          sched-entry open 200000000 -1 8000000 \
>>          sched-entry close 100000000 -1 -1
>
>>From the insight that Vladimir gave, it really makes it easier for me to
>understand if you added these filters and actions in two steps. The
>first, you would add the "time based" actions and the second you would
>plug the filters into the actions. And I think this would match real
>world usage better.
I agree.

/Allan