linux-kernel - 答复: [PATCH -next] PCI: dwc: Make hisi_pcie_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C3CD0DF8AD11A84CB25A1426DE537C61E5951DC6@dggeml524-mbx.china.huawei.com>
Date:   Thu, 23 Apr 2020 03:09:20 +0000
From:   "Zouwei (Samuel)" <zou_wei@...wei.com>
To:     "Wangzhou (B)" <wangzhou1@...ilicon.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "amurray@...goodpenguin.co.uk" <amurray@...goodpenguin.co.uk>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static

Hi Wang,

Thanks for your review and reply.
I will modify and send the v2 soon.

Thanks
Zou Wei
-----邮件原件-----
发件人: Wangzhou (B) 
发送时间: 2020年4月23日 10:59
收件人: Zouwei (Samuel) <zou_wei@...wei.com>; lorenzo.pieralisi@....com; amurray@...goodpenguin.co.uk; bhelgaas@...gle.com
抄送: linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static

On 2020/4/22 17:47, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
> symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/pci/controller/dwc/pcie-hisi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..b440f40 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,8 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
>  	return 0;
>  }
>  
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
> +	}

why adding "}"? BTW, static is OK here.

>  	.bus_shift    = 20,
>  	.init         =  hisi_pcie_platform_init,
>  	.pci_ops      = {
>