linux-kernel - Re: [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f04980f-6f0b-8028-82b5-860321508e69@intel.com>
Date:   Thu, 23 Apr 2020 09:40:42 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Zou Wei <zou_wei@...wei.com>, ulf.hansson@...aro.org
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mmc: sdhci-pci-o2micro: Make some symbols static

On 23/04/20 9:43 am, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/mmc/host/sdhci-pci-o2micro.c:497:6: warning: symbol
> 'sdhci_pci_o2_set_clock' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:512:5: warning: symbol
> 'sdhci_pci_o2_probe_slot' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:581:5: warning: symbol
> 'sdhci_pci_o2_probe' was not declared. Should it be static?
> drivers/mmc/host/sdhci-pci-o2micro.c:786:5: warning: symbol
> 'sdhci_pci_o2_resume' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-pci-o2micro.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index fa81050..e2a8468 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -494,7 +494,7 @@ static void sdhci_o2_enable_clk(struct sdhci_host *host, u16 clk)
>  	}
>  }
>  
> -void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
> +static void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
>  {
>  	u16 clk;
>  
> @@ -509,7 +509,7 @@ void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
>  	sdhci_o2_enable_clk(host, clk);
>  }
>  
> -int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
> +static int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
>  {
>  	struct sdhci_pci_chip *chip;
>  	struct sdhci_host *host;
> @@ -578,7 +578,7 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
>  	return 0;
>  }
>  
> -int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
>  {
>  	int ret;
>  	u8 scratch;
> @@ -783,7 +783,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
>  }
>  
>  #ifdef CONFIG_PM_SLEEP
> -int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
>  {
>  	sdhci_pci_o2_probe(chip);
>  	return sdhci_pci_resume_host(chip);
>