linux-kernel - Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200423094939.os74dohwkdoig4eq@gilmour.lan>
Date:   Thu, 23 Apr 2020 11:49:39 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

On Wed, Apr 22, 2020 at 06:50:54PM -0500, Samuel Holland wrote:
> Maxime,
> 
> On 4/22/20 10:16 AM, Maxime Ripard wrote:
> > On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
> >> As of v5.7-rc2, Linux now prints the following message at boot:
> >>
> >>   [   33.848525] platform sound_spdif: deferred probe pending
> >>
> >> This is because &sound_spdif is waiting on its DAI link component
> >> &spdif to probe, but &spdif is disabled in the DTS. Disable the
> >> audio card as well to match.
> >>
> >> Signed-off-by: Samuel Holland <samuel@...lland.org>
> > 
> > The patch looks good, but don't we have some boards with SPDIF enabled that
> > should be modified accordingly?
> 
> I don't see any in-tree. The only A64 DTS that references &spdif at all is
> sun50i-a64-pine64.dts, which explicitly disables it:
> 
> 	/* On Euler connector */
> 	&spdif {
>   		status = "disabled";
> 	};
> 
> I'm leaning toward agreeing with Clement that the sound_spdif node (and also
> spdif_out) should be removed altogether from the A64 DTSI.

Yeah, I agree, it's pretty much what we've been doing in other SoCs. Especially
if we don't have any DT in-tree using it, we don't really have any incentive to
make it common.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)