linux-kernel - Re: [PATCH] staging: wfx: cleanup long lines in data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 13:34:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>
Cc:     Suraj Upadhyay <usuraj35@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: wfx: cleanup long lines in data_tx.c

On Thu, Apr 23, 2020 at 09:29:28AM +0000, Jerome Pouiller wrote:
> >         req->data_flags.fc_offset = offset;
> >         if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM)
> >                 req->data_flags.after_dtim = 1;
> > @@ -517,7 +523,8 @@ void wfx_tx_confirm_cb(struct wfx_vif *wvif, const struct hif_cnf_tx *arg)
> >                 if (tx_count < rate->count &&
> >                     arg->status == HIF_STATUS_RETRY_EXCEEDED &&
> >                     arg->ack_failures)
> > -                       dev_dbg(wvif->wdev->dev, "all retries were not consumed: %d != %d\n",
> > +                       dev_dbg(wvif->wdev->dev,
> > +                               "all retries were not consumed: %d != %d\n",
> 
> Is this reported by checkpatch? The strings can exceed 80 columns.
> 

The string can go over 80 characters, but it's nice to do our best to
avoid it so we do normally break it up like this where the string is
on its own line.

regards,
dan carpenter