linux-kernel - Re: [PATCH 2/3] dt-bindings: regulator: Add document bindings for max77826

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9b5d68d-536b-5806-573b-9dafb848f46f@gmail.com>
Date:   Thu, 23 Apr 2020 15:59:34 +0300
From:   Iskren Chernev <iskren.chernev@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        devicetree@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/3] dt-bindings: regulator: Add document bindings for
 max77826


On 4/20/20 11:55 PM, Rob Herring wrote:
> On Mon, Apr 13, 2020 at 07:44:39PM +0300, Iskren Chernev wrote:
>> +    patternProperties:
>> +      "^LDO([1-9]|1[0-5])$":
>> +        type: object
>> +        allOf:
>> +          - $ref: regulator.yaml#
>> +
>> +      "^BUCK|BUCKBOOST$":
>> +        type: object
>> +        allOf:
>> +          - $ref: regulator.yaml#
>> +
>> +      additionalProperties: false
>
> You are defining a property called 'additionalProperties'. This one
> should be dropped because additionalProperties doesn't work with a $ref.
>

I got the idea from mps,mpq7920.yaml. It has additionalProperties in the
exact same places that I do. Also bd718(28|37|47).yaml seem to use
additionalProperties inside patternProperties. Shall I modify it as well?

I couldn't find the core schema for this yaml:
http://devicetree.org/meta-schemas/core.yaml (gives 404).  Is there a way
to verify the validity of the yaml?

Also, this patch is already merged in linux-next. I guess I shall submit
a new patch with the fixes standalone?