linux-kernel - Re: [PATCH v9 0/5] usb: xhci: Add support for Renesas USB controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 18:40:00 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        John Stultz <john.stultz@...aro.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Andreas Böhler <dev@...ehler.at>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 0/5] usb: xhci: Add support for Renesas USB controllers

On 14-04-20, 22:11, Vinod Koul wrote:
> This series add support for Renesas USB controllers uPD720201 and uPD720202.
> These require firmware to be loaded and in case devices have ROM those can
> also be programmed if empty. If ROM is programmed, it runs from ROM as well.
> 
> This includes patches from Christian which supported these controllers w/o
> ROM and later my patches for ROM support and debugfs hook for rom erase and
> export of xhci-pci functions.

Any feedback Mathias ?

> 
> Changes in v9:
>  Make fw load a sync call and have single instance of probe execute,
>    elimating probe/remove races
>  Add quirk for renesas and use that for loading
> 
> Changes in v8:
>  Fix compile error reported by Kbuild-bot by making usb_hcd_pci_probe() take
>  const struct hc_driver * as argument
> 
> Changes in v7:
>  Make a single module which removes issues with module loading
>  Keep the renesas code in renesas file
>  Add hc_driver as argument for usb_hcd_pci_probe and modify hdc drivers to
>    pass this and not use driver_data
>  Use driver data for fw name
>  Remove code to check if we need to load firmware or not
>  remove multiple fw version support, we can do that with symlink in
>    userspace
> 
> Changes in v6:
>  Move the renesas code into a separate driver which invokes xhci-pci functions.
> 
> Changes in v5:
>  Added a debugfs rom erase patch, helps in debugging
>  Squashed patch 1 & 2 as requested by Mathias
> 
> Changes in v4:
>  Rollback the delay values as we got device failures
> 
> Changes in v3:
>   Dropped patch 2 as discussed with Christian
>   Removed aligned 8 bytes check
>   Change order for firmware search from highest version to lowest
>   Added entry for new firmware for device 0x14 as well
>   Add tested by Christian
> 
> Changes in v2:
>   used macros for timeout count and delay
>   removed renesas_fw_alive_check
>   cleaned renesas_fw_callback
>   removed recurion for renesas_fw_download
>   added MODULE_FIRMWARE
>   added comment for multiple fw order
> 
> Christian Lamparter (1):
>   usb: renesas-xhci: Add the renesas xhci driver
> 
> Vinod Koul (4):
>   usb: hci: add hc_driver as argument for usb_hcd_pci_probe
>   usb: xhci: Add support for Renesas controller with memory
>   usb: renesas-xhci: Add ROM loader for uPD720201
>   usb: xhci: provide a debugfs hook for erasing rom
> 
>  drivers/usb/core/hcd-pci.c          |   7 +-
>  drivers/usb/host/Makefile           |   3 +-
>  drivers/usb/host/ehci-pci.c         |   6 +-
>  drivers/usb/host/ohci-pci.c         |   9 +-
>  drivers/usb/host/uhci-pci.c         |   8 +-
>  drivers/usb/host/xhci-pci-renesas.c | 740 ++++++++++++++++++++++++++++
>  drivers/usb/host/xhci-pci.c         |  47 +-
>  drivers/usb/host/xhci-pci.h         |  16 +
>  drivers/usb/host/xhci.h             |   1 +
>  include/linux/usb/hcd.h             |   3 +-
>  10 files changed, 817 insertions(+), 23 deletions(-)
>  create mode 100644 drivers/usb/host/xhci-pci-renesas.c
>  create mode 100644 drivers/usb/host/xhci-pci.h
> 
> -- 
> 2.25.1

-- 
~Vinod