linux-kernel - RE: [PATCH -next] hwrng: cctrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0802MB2533C82FFC907FDFF331C312E9D30@DB6PR0802MB2533.eurprd08.prod.outlook.com>
Date:   Thu, 23 Apr 2020 14:00:44 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     Zou Wei <zou_wei@...wei.com>, "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        nd <nd@....com>
Subject: RE: [PATCH -next] hwrng: cctrng - Make some symbols static


> -----Original Message-----
> From: Zou Wei <zou_wei@...wei.com>
> Sent: Thursday, 23 April 2020 15:21
> 
> Fix the following sparse warnings:
> 
> drivers/char/hw_random/cctrng.c:316:6: warning: symbol
> 'cc_trng_compwork_handler' was not declared. Should it be static?
> drivers/char/hw_random/cctrng.c:451:6: warning: symbol
> 'cc_trng_startwork_handler' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/char/hw_random/cctrng.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/hw_random/cctrng.c
> b/drivers/char/hw_random/cctrng.c index e82716c..3ff37a6 100644
> --- a/drivers/char/hw_random/cctrng.c
> +++ b/drivers/char/hw_random/cctrng.c
> @@ -313,7 +313,7 @@ static void cc_trng_hw_trigger(struct cctrng_drvdata
> *drvdata)
>  	cc_trng_enable_rnd_source(drvdata);
>  }
> 
> -void cc_trng_compwork_handler(struct work_struct *w)
> +static void cc_trng_compwork_handler(struct work_struct *w)
>  {
>  	u32 isr = 0;
>  	u32 ehr_valid = 0;
> @@ -448,7 +448,7 @@ static irqreturn_t cc_isr(int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
> 
> -void cc_trng_startwork_handler(struct work_struct *w)
> +static void cc_trng_startwork_handler(struct work_struct *w)
>  {
>  	struct cctrng_drvdata *drvdata =
>  			container_of(w, struct cctrng_drvdata, startwork);
> --
> 2.6.2

Acked-by: Hadar Gat <hadar.gat@....com>