linux-kernel - Re: [PATCH v1] drm/bochs: fix an issue of ioremap() leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 22:14:16 +0800
From:   Dejin Zheng <zhengdejin5@...il.com>
To:     Gerd Hoffmann <kraxel@...hat.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        virtualization@...ts.linux-foundation.org,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] drm/bochs: fix an issue of ioremap() leak

On Thu, Apr 23, 2020 at 12:14:20PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > I am a newbie, andy gave me some directions to submit the patch, eg: check
> > ioremap leak. At this time, I found that the bochs driver may have similar
> > problems, so I submitted this patch, then, Andy said the best is to switch
> > this driver to use pcim _ * () functions and drop tons of legacy code.
> > I think we might be able to fix this issue first, after that, drop tons
> > of legacy code by pcim_*() functions. Can you give me some suggestions?
> > thank you very much!
> 
> drm has drmm_* functions for that.  Daniel Vetter <daniel@...ll.ch> has
> a patch series pending switching lots of drivers over and IIRC it fixes
> this bug too.
>
Gerd, Thanks for your info and abandon this commit. 

BR,
Dejin

> cheers,
>   Gerd
>