linux-kernel - Re: [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Apr 2020 17:19:17 +0300
From:   Daniel Baluta <daniel.baluta@....com>
To:     Anson Huang <Anson.Huang@....com>, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        rui.zhang@...el.com, daniel.lezcano@...aro.org,
        amit.kucheria@...durent.com, robh+dt@...nel.org,
        leonard.crestez@....com, linux@...pel-privat.de, peng.fan@....com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pm@...r.kernel.org0001-dt-bindings-firmware-imx-Move-system-control-into-dt.patch
Cc:     Linux-imx@....com
Subject: Re: [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h

On 4/23/20 4:59 PM, Anson Huang wrote:
> The linux/firmware/imx/types.h has been merged into
> dt-bindings/firmware/imx/rsrc.h, change the includes
> in imx_sc_thermal.c driver accordingly.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>   drivers/thermal/imx_sc_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index b2b68c9..b01d28e 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -3,9 +3,9 @@
>    * Copyright 2018-2020 NXP.
>    */
>   
> +#include <dt-bindings/firmware/imx/rsrc.h>
>   #include <linux/err.h>
>   #include <linux/firmware/imx/sci.h>
> -#include <linux/firmware/imx/types.h>
>   #include <linux/module.h>
>   #include <linux/of.h>
>   #include <linux/of_device.h>


You should do the operation of removing the header file and updating the 
*.c files in one single patch.

Otherwise, we will break bisection. There will be states of the linux 
kernel tree that do not compile.