lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Apr 2020 22:26:27 +0800 From: Dejin Zheng <zhengdejin5@...il.com> To: gregkh@...uxfoundation.org, tglx@...utronix.de, FlorianSchandinat@....de, b.zolnierkie@...sung.com, ralf@...ux-mips.org, tsbogend@...ha.franken.de, dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Dejin Zheng <zhengdejin5@...il.com>, Andy Shevchenko <andy.shevchenko@...il.com> Subject: [PATCH v2] console: console: Complete exception handling in newport_probe() A call of the function ¡°do_take_over_console¡± can fail here. The corresponding system resources were not released then. Thus add a call of the function ¡°iounmap¡± together with the check of a failure predicate. Fixes: e84de0c6190503 ("MIPS: GIO bus support for SGI IP22/28") CC: Andy Shevchenko <andy.shevchenko@...il.com> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com> --- v1 -> v2: - modify the commit comments by Markus'suggestion. drivers/video/console/newport_con.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c index 00dddf6e08b0..6bfc8e3ffd4a 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -720,6 +720,9 @@ static int newport_probe(struct gio_device *dev, console_lock(); err = do_take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1); console_unlock(); + + if (err) + iounmap((void *)npregs); return err; } -- 2.25.0
Powered by blists - more mailing lists