linux-kernel - Re: [linux-sunxi] [PATCH v2 1/2] media: cedrus: Program output format during each run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2018061.irdbgypaU6@jernej-laptop>
Date:   Thu, 23 Apr 2020 19:40:57 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     Maxime Ripard <mripard@...nel.org>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-sunxi@...glegroups.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org, linux-sunxi@...glegroups.com,
        Samuel Holland <samuel@...lland.org>, samuel@...lland.org
Subject: Re: [linux-sunxi] [PATCH v2 1/2] media: cedrus: Program output format during each run

Dne sreda, 22. april 2020 ob 06:04:09 CEST je Samuel Holland napisal(a):
> Previously, the output format was programmed as part of the ioctl()
> handler. However, this has two problems:
> 
>   1) If there are multiple active streams with different output
>      formats, the hardware will use whichever format was set last
>      for both streams. Similary, an ioctl() done in an inactive
>      context will wrongly affect other active contexts.
>   2) The registers are written while the device is not actively
>      streaming. To enable runtime PM tied to the streaming state,
>      all hardware access needs to be moved inside cedrus_device_run().
> 
> The call to cedrus_dst_format_set() is now placed just before the
> codec-specific callback that programs the hardware.
> 
> Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
> Suggested-by: Jernej Škrabec <jernej.skrabec@...il.com>
> Suggested-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> Signed-off-by: Samuel Holland <samuel@...lland.org>

For what is worth:
Tested-by: Jernej Skrabec <jernej.skrabec@...l.net>
Reviewed-by: Jernej Skrabec <jernej.skrabec@...l.net>

Best regards,
Jernej