linux-kernel - Re: [PATCH] random: Document add_hwgenerator_randomness() with other input functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1465fdf4-3197-f184-04c2-8a0882f19557@infradead.org>
Date:   Fri, 24 Apr 2020 09:03:19 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mark Brown <broonie@...nel.org>, Theodore Ts'o <tytso@....edu>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] random: Document add_hwgenerator_randomness() with other
 input functions

On 4/24/20 5:39 AM, Mark Brown wrote:
> The section at the top of random.c which documents the input functions
> available does not document add_hwgenerator_randomness() which might lead
> a reader to overlook it. Add a brief note about it.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  drivers/char/random.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 0d10e31fd342..ba2dc45bf718 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -228,6 +228,14 @@
>   * particular randomness source.  They do this by keeping track of the
>   * first and second order deltas of the event timings.
>   *
> + * There is also an interface for true hardware RNGs:
> + *
> + *	void add_hwgenerator_randomness(const char *buffer, size_t count,
> + *				size_t entropy);
> + *
> + * This will credit entropy as specified by the caller, if the entropy

Use a ';' or '.' instead of ','. (and "If" if a period is used)

> + * pool is full it will block until more entropy is needed.
> + *
>   * Ensuring unpredictability at system startup
>   * ============================================
>   *
> 

Otherwise looks good. Thanks.

-- 
~Randy