linux-kernel - Re: [PATCH] scsi: aic7xxx: Remove unnecessary NULL checks before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1imhoesm2.fsf@oracle.com>
Date:   Fri, 24 Apr 2020 12:49:41 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Alex Dewar <alex.dewar@....co.uk>
Cc:     Hannes Reinecke <hare@...e.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: Remove unnecessary NULL checks before kfree


Alex,

> There are a number of places in the aic7xxx driver where a NULL check
> is performed before a kfree(). However, kfree() already performs NULL
> checks so this is unnecessary. Remove the checks.
>
> Issue identified with Coccinelle.

Applied to 5.8/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering