linux-kernel - RE: [PATCH v2] IB/rdmavt: return proper error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY5PR11MB395888228F5FCA3861A21AE086D00@BY5PR11MB3958.namprd11.prod.outlook.com>
Date:   Fri, 24 Apr 2020 16:59:30 +0000
From:   "Marciniszyn, Mike" <mike.marciniszyn@...el.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        "Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [PATCH v2] IB/rdmavt: return proper error code

> Subject: [PATCH v2] IB/rdmavt: return proper error code
> 
> The commit 'ff23dfa13457' modified rvt_create_mmap_info() to return
> error code and also NULL but missed fixing codes which called
> rvt_create_mmap_info(). Modify rvt_create_mmap_info() to only return
> errorcode and fix error checking after rvt_create_mmap_info() was
> called.
> 
> Fixes: ff23dfa13457 ("IB: Pass only ib_udata in function prototypes")
> Cc: stable@...r.kernel.org [5.4+]
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>

I just tested the exact same patch!

Just a nit, adjust the comments for rvt_create_mmap_info():

* Return: rvt_mmap struct on success, ERR_PTR on failure

Tested-by: Mike Marciniszyn <mike.marciniszyn@...el.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@...el.com>

Mike